Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10343] Removed cluster between web, collector #10350

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[#10343] Removed cluster between web, collector #10350

merged 1 commit into from
Sep 19, 2023

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Sep 19, 2023

No description provided.

@smilu97 smilu97 self-assigned this Sep 19, 2023
@smilu97 smilu97 force-pushed the 10343_remove_cluster branch 2 times, most recently from 71f9b4b to 3bdc589 Compare September 19, 2023 05:20
@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 10.35% and project coverage change: +0.08% 🎉

Comparison is base (2b95dd2) 37.87% compared to head (4ac7506) 37.96%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #10350      +/-   ##
============================================
+ Coverage     37.87%   37.96%   +0.08%     
+ Complexity    11959    11802     -157     
============================================
  Files          3762     3736      -26     
  Lines         96498    94639    -1859     
  Branches      10624    10387     -237     
============================================
- Hits          36546    35925     -621     
+ Misses        56853    55687    -1166     
+ Partials       3099     3027      -72
Files Changed Coverage Δ
...inpoint/collector/cluster/AgentConnectionImpl.java 0.00% <0.00%> (ø)
...llector/cluster/AgentConnectionRepositoryImpl.java 0.00% <0.00%> (ø)
...oint/collector/cluster/ClusterPointRepository.java 37.20% <ø> (+9.54%) ⬆️
...pinpoint/collector/cluster/ClusterPointRouter.java 0.00% <0.00%> (ø)
...point/collector/cluster/ClusterServiceFactory.java 0.00% <0.00%> (ø)
...pinpoint/collector/cluster/ClusterServiceImpl.java 0.00% <0.00%> (ø)
...point/collector/cluster/DisableClusterService.java 0.00% <ø> (ø)
...lector/cluster/DisabledProfilerClusterManager.java 0.00% <ø> (ø)
...inpoint/collector/cluster/GrpcAgentConnection.java 29.03% <0.00%> (+0.90%) ⬆️
.../cluster/RealtimeCollectorModuleAdaptorConfig.java 0.00% <0.00%> (ø)
... and 43 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smilu97 smilu97 merged commit 5508188 into pinpoint-apm:master Sep 19, 2023
2 of 3 checks passed
@smilu97 smilu97 deleted the 10343_remove_cluster branch September 19, 2023 07:48
@smilu97 smilu97 linked an issue Sep 19, 2023 that may be closed by this pull request
Removing legacy cluster connections #10343
Closed
smilu97 pushed a commit to smilu97/pinpoint that referenced this pull request Oct 26, 2023
[pinpoint-apm#10350] Removed zookeeper tests
023f0d3
smilu97 pushed a commit that referenced this pull request Oct 26, 2023
@smilu97
[#10350] Removed zookeeper tests
f6f1979
gipyeong-lee pushed a commit to gipyeong-lee/pinpoint that referenced this pull request Nov 1, 2023
@gipyeong-lee
[pinpoint-apm#10350] Removed zookeeper tests
0b6122f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smilu97 smilu97

Labels
module:collector module:web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing legacy cluster connections
1 participant
@smilu97